Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add visualization postprocessor for the maximum shear stress #3071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MFraters
Copy link
Member

It should work, but I need to update the documentation.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of things that you'll have to update, I think.

/**
* A class that computes a field of horizontal vectors that
* represent the direction of maximal horizontal compressive
* stress. For an exact definition, see the documentation of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to update this -- it's not the compressive, but the shear stress I believe

// lead to numerical instabilities)
//
// note that the *compressive* stress is simply the
// negative stress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

const double eta = out.viscosities[q];

// first compute the stress tensor, ignoring the pressure
// for the moment (the pressure has no effect on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this still apply? in contrast to the place where you copied this from, here you really don't care about the pressure, right?

ASPECT_REGISTER_VISUALIZATION_POSTPROCESSOR(MaximumShearStress,
"maximum shear stress",
"A plugin that computes the direction and magnitude of the "
"maximum horizontal component of the compressive stress as a vector "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to read through this again and see which parts need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants