Fix the units for the darcy velocity postprocessor #6129
Conversation
danieldouglas92
force-pushed
the
fix_units_in_darcy_velocity_viz
branch
from
ac71f79 to
7c5f19c
Compare
|
I'm not sure why the dealii-master tests suite is failing, but this seems like something outside of the scope of this PR? |
|
/rebuild |
There was a problem hiding this comment.
Nice find. The failing test for deal.II master was unrelated and should be fixed, I restarted the tester to double check.
However, since none of our own tests are failing that means we currently have no test for this postprocessor. Would it be hard to add one either in this PR or as a follow-up?
|
There is actually a test for this postprocessor in |
that would be great! |
danieldouglas92
force-pushed
the
fix_units_in_darcy_velocity_viz
branch
from
7c5f19c to
5f12048
Compare
|
I decided it would be best to just update the existing test and make the solid velocity non-zero, there wasn't an existing test where it would be clear to see that the solid velocity was properly being taken into account in the post-processing. |
danieldouglas92
force-pushed
the
fix_units_in_darcy_velocity_viz
branch
from
5f12048 to
7fa2dc0
Compare
|
/rebuild |
There was a problem hiding this comment.
Most often it is best to add new tests instead of modifying existing ones, because we want tests to be specific to one feature. That being said, in this case the existing test was to test exactly this and just wasnt working as expected. So we can go ahead with this PR. One of the tester machines had trouble (likely unrelated to your PR). I restarted the testers, if they pass this is ready to merge. 👍
Within the darcy velocity postprocessor, the multiplier which converts the units of the darcy velocity to years instead of seconds was not being multiplied by the solid velocity, this PR fixes this unit discrepancy.