fix latent heat viscosity prefactor #6214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Jan 24, 2025
| @@ -131,18 +136,27 @@ namespace aspect | |||
| // for the first layer, so we have to use phase+1 as the index. | |||
| if (composition.size()==0) | |||
| { | |||
| phase_dependence += phaseFunction * density_jumps[phase]; | |||
| viscosity_phase_dependence *= 1. + phaseFunction * (phase_prefactors[phase+1]-1.); | |||
| phase_dependence += phaseFunction * density_jumps[transition_index]; | |||
There was a problem hiding this comment.
can you fix/delete the comment 3 lines above?
source/material_model/latent_heat.cc
Outdated
|
|
||
| // Viscosities | ||
| if (transition_index+1 < phase_function.n_phases_for_each_composition()[0]) // 1st compositional field | ||
| viscosity_phase_prefactors[0] = std::pow(10, |
There was a problem hiding this comment.
Suggested change
| viscosity_phase_prefactors[0] = std::pow(10, | |
| viscosity_phase_prefactors[0] = std::pow(10., |
source/material_model/latent_heat.cc
Outdated
| + (1. - phaseFunction) * std::log10(viscosity_phase_prefactors[0])); | ||
| else if (transition_index+2 < phase_function.n_phases_for_each_composition()[0] | ||
| + phase_function.n_phases_for_each_composition()[1]) // 2nd compositional field | ||
| viscosity_phase_prefactors[1] = std::pow(10, |
There was a problem hiding this comment.
Suggested change
| viscosity_phase_prefactors[1] = std::pow(10, | |
| viscosity_phase_prefactors[1] = std::pow(10., |
source/material_model/latent_heat.cc
Outdated
| if (composition.size()==0) | ||
| out.viscosities[i] = out.viscosities[i]*viscosity_phase_prefactors[0]; | ||
| else | ||
| out.viscosities[i] = (std::pow(10, ((1-composition[0]) * std::log10(out.viscosities[i]*viscosity_phase_prefactors[0]) |
There was a problem hiding this comment.
Suggested change
| out.viscosities[i] = (std::pow(10, ((1-composition[0]) * std::log10(out.viscosities[i]*viscosity_phase_prefactors[0]) | |
| out.viscosities[i] = (std::pow(10., ((1-composition[0]) * std::log10(out.viscosities[i]*viscosity_phase_prefactors[0]) |
source/material_model/latent_heat.cc
Outdated
| "viscosity (modified by any compositional prefactors) will be multiplied " | ||
| "by this factor to get the corresponding viscosity for each phase. " | ||
| "List must have the same number of entries as there are phases, that is one " | ||
| "more than Phase transition depths for each composition that is used in the " |
There was a problem hiding this comment.
do you want to quote this parameter?
jdannberg
force-pushed
the
latent_heat_viscosity
branch
from
1299048 to
38227d4
Compare
jdannberg
force-pushed
the
latent_heat_viscosity
branch
from
38227d4 to
2b2b703
Compare
|
@tjhei Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of viscosity prefactors that would change the viscosity at phase transitions in the latent heat material model did not work correctly if more than one compositional field was used. Specifically, individual layers would have the wrong viscosities, and the length of the list of prefactors that had to be specified in the input file made no sense. This specific setup had no test case, which is likely why we did not notice when we broke this.
The problem was that the prefactors are specified relative to each other, but when they are applied, they are multiplied on top of each other (due to the way the phase function works). This means they have to be scaled after they are read in, and this scaling depends on how many phase transitions are occurring above a given phase, and the old interface just had no good way of figuring that out. Therefore, there was no good way for fixing this without also changing the interface for this input parameter. I changed the interface to be consistent with what we use for all other phase transition parameters (the map parsing from the material model utilities), which has the advantage that there's a good default for models with and without chemical heterogeneities. I also fixed the computation of the viscosities in the individual phases, and changed the averaging between phases to a log average (which is consistent with the rest of the material model, which already uses log averaging for viscosities).
For new features/models or changes of existing features: