Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Geltungsbereiche): add PDF export with export menu for GB topics #1128

Merged
merged 77 commits into from
Feb 26, 2024
Merged

feat(Geltungsbereiche): add PDF export with export menu for GB topics #1128

merged 77 commits into from
Feb 26, 2024

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Jan 9, 2024 •
edited
Loading

How to

In both GB topics a map button has been added. It opens a Modal with export options and an ExportButton to generate a PDF.

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@danji90 danji90 marked this pull request as draft January 9, 2024 16:29
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:02am
trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:02am

@danji90 danji90 changed the title feat(Geltungsbereiche). add PDF export with export menu for GB topics feat(Geltungsbereiche): add PDF export with export menu for GB topics Jan 9, 2024
@danji90 danji90 self-assigned this Jan 9, 2024
@danji90 danji90 added enhancement New feature or request feature labels Feb 21, 2024
@danji90 danji90 marked this pull request as ready for review February 26, 2024 15:40
@danji90 danji90 merged commit 7503b2e into master Feb 26, 2024
13 checks passed
@oterral oterral deleted the daniel/gaPdfExport branch November 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oterral oterral oterral requested changes

@friedjoff friedjoff Awaiting requested review from friedjoff friedjoff is a code owner

@gevos gevos Awaiting requested review from gevos

Assignees

@danji90 danji90

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danji90 @oterral