Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geltungsbereiche): fix button and layer styling for iframes #1141

Merged
merged 11 commits into from
Feb 12, 2024
Merged

fix(geltungsbereiche): fix button and layer styling for iframes #1141

merged 11 commits into from
Feb 12, 2024

Conversation

gevos
Copy link
Contributor

@gevos gevos commented Feb 5, 2024 •
edited
Loading

How to

https://dev-trafimage-maps-git-eva-tdgbauto-136-iframe-geops.vercel.app/ch.sbb.geltungsbereiche-iframe
or
https://localhost:3000/ch.sbb.geltungsbereiche-iframe

and have a look at the info button in the topic menu

Others

  • It's not a hack or at least an unauthorized hack :).
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 0:46am
trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 0:46am

@gevos gevos changed the title fix(geltungsbereiche): fix padding for iframes to avoid text/info but… fix(geltungsbereiche): fix text/info button conflict for iframes Feb 5, 2024
@gevos gevos marked this pull request as ready for review February 9, 2024 08:52
friedjoff
friedjoff approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@friedjoff friedjoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gevos gevos changed the title fix(geltungsbereiche): fix text/info button conflict for iframes fix(geltungsbereiche): fix button and layer styling for iframes Feb 12, 2024
@gevos gevos merged commit e330633 into master Feb 12, 2024
14 checks passed
@oterral oterral deleted the eva/TDGBAUTO-136-iframe branch November 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedjoff friedjoff friedjoff approved these changes

@danji90 danji90 Awaiting requested review from danji90 danji90 is a code owner

@oterral oterral Awaiting requested review from oterral oterral is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gevos @friedjoff