Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing performance bug in Perl implementation #68

Open
wants to merge 6 commits into
base: perl
Choose a base branch
from
Open

fixing performance bug in Perl implementation #68

wants to merge 6 commits into from

Conversation

getify
Copy link
Owner

@getify getify commented Dec 15, 2021 •
edited
Loading

See #64

NOTE: this is not yet ready, as there's still a FIXME to resolve on this line: f80d978#diff-67dad0d447d0301fffaaab6e42c4cf7129200818c5edbf19531fd115eb2f098bR127

@getify getify mentioned this pull request Dec 15, 2021
Open
@getify
Copy link
Owner Author

getify commented Dec 15, 2021

Hmmm, so seems tests are failing here? Bummer.

@yurikhan
Copy link

Ha, yes. substr expects its third argument to specify substring length, not end position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurikhan yurikhan yurikhan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getify @yurikhan