Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getenv() for KIRBY_HOST #84

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

tillschander
Copy link

The contents of $_ENV might be empty, even though environment variables are present:
https://stackoverflow.com/questions/3780866/why-is-my-env-empty

For example:

  • The php.ini can disallow filling the of $_ENV
  • Variables could end up in $_SERVER instead of $_ENV

By using getenv() instead of $_ENV we can fix some of those issues because it is a bit more liberal when it comes to the detection of environment variables.

@bastianallgeier bastianallgeier changed the base branch from main to develop January 8, 2025 12:06
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bastianallgeier bastianallgeier merged commit 5cf04a8 into getkirby:develop Jan 8, 2025
4 of 5 checks passed
@bastianallgeier bastianallgeier added this to the 1.6.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants