Add more unit tests

src/Panel/Document.php

@@ -30,6 +30,9 @@ public function __construct()
 		$this->kirby = App::instance();
 	}
 
+	/**
+	 * Panel assets
+	 */
 	public function assets(): Assets
 	{
 		return $this->assets ??= new Assets();
@@ -67,7 +70,7 @@ public function cors(): string
 	}
 
 	/**
-	 * Renders the panel document
+	 * Renders the Panel document
 	 */
 	public function render(array $fiber): Response
 	{

src/Panel/Fiber.php

@@ -122,11 +122,6 @@ public function filter(array $data): array
 			// split include string into an array of fields
 			$keys = Str::split($filter, ',');
 
-			// if a full request is made, return all data
-			if ($keys === []) {
-				return $data;
-			}
-
 			// take care of potentially requested globals
 			$globals     = $this->globals();
 			$keysEntries = A::map($keys, fn ($key) => Str::split($key, '.')[0]);
@@ -157,10 +152,6 @@ public function filter(array $data): array
 			$keys = Str::split($filterGlobals, ',');
 
 			// add requested globals
-			if ($keys === []) {
-				return $data;
-			}
-
 			$globals = $this->globals();
 
 			foreach ($keys as $key) {
@@ -319,6 +310,11 @@ public function translation(): array
 		];
 	}
 
+	public function url(): string
+	{
+		return $this->kirby->request()->url()->toString();
+	}
+
 	public function urls(): array
 	{
 		return [
@@ -327,11 +323,6 @@ public function urls(): array
 		];
 	}
 
-	public function url(): string
-	{
-		return $this->kirby->request()->url()->toString();
-	}
-
 	public function user(): array|null
 	{
 		if ($this->user) {

tests/Panel/AreasTest.php

@@ -8,6 +8,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Areas
+ * @covers ::__construct
  */
 class AreasTest extends TestCase
 {

tests/Panel/AssetsTest.php

@@ -11,6 +11,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Assets
+ * @covers ::__construct
  */
 class AssetsTest extends TestCase
 {

tests/Panel/DocumentTest.php

@@ -9,6 +9,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Document
+ * @covers ::__construct
  */
 class DocumentTest extends TestCase
 {

tests/Panel/FiberTest.php

@@ -11,6 +11,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Fiber
+ * @covers ::__construct
  */
 class FiberTest extends TestCase
 {
@@ -35,6 +36,23 @@ public function tearDown(): void
 		Dir::remove(static::TMP);
 	}
 
+	/**
+	 * @covers ::config
+	 */
+	public function testConfig(): void
+	{
+		// without custom data
+		$fiber = new Fiber();
+		$config  = $fiber->config();
+		$config = A::apply($config);
+
+		$this->assertArrayHasKey('api', $config);
+		$this->assertArrayHasKey('debug', $config);
+		$this->assertArrayHasKey('kirbytext', $config);
+		$this->assertArrayHasKey('translation', $config);
+		$this->assertArrayHasKey('upload', $config);
+	}
+
 	/**
 	 * @covers ::data
 	 */
@@ -176,7 +194,7 @@ public function testFilterOnlyRequest(): void
 	/**
 	 * @covers ::filter
 	 */
-	public function testFilterOnlyrequestWithGlobal(): void
+	public function testFilterOnlyRequestWithGlobal(): void
 	{
 		// simulate a simple partial request
 		$this->app = $this->app->clone([
@@ -480,6 +498,83 @@ public function testSearches()
 		$this->assertArrayHasKey('test', $searches);
 	}
 
+	/**
+	 * @covers ::system
+	 */
+	public function testSystem(): void
+	{
+		// without custom data
+		$fiber   = new Fiber();
+		$system  = $fiber->system();
+		$system = A::apply($system);
+
+		$this->assertArrayHasKey('ascii', $system);
+		$this->assertArrayHasKey('csrf', $system);
+		$this->assertArrayHasKey('isLocal', $system);
+		$this->assertArrayHasKey('locales', $system);
+		$this->assertArrayHasKey('slugs', $system);
+		$this->assertArrayHasKey('title', $system);
+	}
+
+	/**
+	 * @covers ::toArray
+	 */
+	public function testToArray(): void
+	{
+		$fiber = new Fiber();
+		$array = $fiber->toArray(globals: false);
+		$this->assertArrayHasKey('user', $array);
+		$this->assertArrayNotHasKey('config', $array);
+
+		$array = $fiber->toArray(globals: true);
+		$this->assertArrayHasKey('user', $array);
+		$this->assertArrayHasKey('config', $array);
+	}
+
+	/**
+	 * @covers ::translation
+	 */
+	public function testTranslation(): void
+	{
+		$fiber       = new Fiber();
+		$translation = $fiber->translation();
+		$translation = A::apply($translation);
+
+		$this->assertSame('en', $translation['code']);
+		$this->assertArrayHasKey('data', $translation);
+		$this->assertSame('ltr', $translation['direction']);
+		$this->assertSame('English', $translation['name']);
+		$this->assertSame(0, $translation['weekday']);
+	}
+
+	/**
+	 * @covers ::translation
+	 */
+	public function testTranslationWithUserLanguage(): void
+	{
+		$this->app = $this->app->clone([
+			'users' => [
+				[
+					'email'    => '[email protected]',
+					'language' => 'de',
+					'role'     => 'admin'
+				]
+			]
+		]);
+
+		$this->app->impersonate('[email protected]');
+
+		$fiber       = new Fiber();
+		$translation = $fiber->translation();
+		$translation = A::apply($translation);
+
+		$this->assertSame('de', $translation['code']);
+		$this->assertArrayHasKey('data', $translation);
+		$this->assertSame('ltr', $translation['direction']);
+		$this->assertSame('Deutsch', $translation['name']);
+		$this->assertSame(1, $translation['weekday']);
+	}
+
 	/**
 	 * @covers ::url
 	 */
@@ -502,6 +597,17 @@ public function testUrl(): void
 		$this->assertSame('https://localhost.com:8888/foo/bar?foo=bar', $url);
 	}
 
+	/**
+	 * @covers ::urls
+	 */
+	public function testUrls(): void
+	{
+		$fiber = new Fiber();
+		$urls  = $fiber->urls();
+		$this->assertArrayHasKey('api', $urls);
+		$this->assertArrayHasKey('site', $urls);
+	}
+
 	/**
 	 * @covers ::permissions
 	 * @covers ::user

tests/Panel/HomeTest.php

@@ -12,6 +12,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Home
+ * @covers ::__construct
  */
 class HomeTest extends TestCase
 {

tests/Panel/PanelTest.php

@@ -9,6 +9,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Panel
+ * @covers ::__construct
  */
 class PanelTest extends TestCase
 {

tests/Panel/RouterTest.php

@@ -9,6 +9,7 @@
 
 /**
  * @coversDefaultClass \Kirby\Panel\Router
+ * @covers ::__construct
  */
 class RouterTest extends TestCase
 {
@@ -170,6 +171,43 @@ public function testRoutesForDialogsWithoutHandlers(): void
 		$this->assertSame('The submit handler is missing', $routes[1]['action']());
 	}
 
+	/**
+	 * @covers ::routesForDrawers
+	 */
+	public function testRoutesForDrawers(): void
+	{
+		$area = [
+			'drawers' => [
+				'test' => [
+					'load'   => $load   = function () {
+					},
+					'submit' => $submit = function () {
+					},
+				]
+			]
+		];
+
+		$routes = Router::routesForDrawers('test', $area);
+
+		$expected = [
+			[
+				'pattern' => 'drawers/test',
+				'type'    => 'drawer',
+				'area'    => 'test',
+				'action'  => $load,
+			],
+			[
+				'pattern' => 'drawers/test',
+				'type'    => 'drawer',
+				'area'    => 'test',
+				'method'  => 'POST',
+				'action'  => $submit,
+			]
+		];
+
+		$this->assertSame($expected, $routes);
+	}
+
 	/**
 	 * @covers ::routesForDropdowns
 	 */