Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags field preview fixes + improvements #6940

Merged
merged 9 commits into from
Jan 24, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 23, 2025

Description

Summary of changes

  • k-tag now supports a link prop
  • k-tags gets rid of unnecessary elementTag prop. element refers again to the HTML element of the individual tag not the tags wrapper element.
  • k-tags-field-preview skips k-tags to avoid a lot of hoop jumping, but rather directly adds k-tag components
  • New k-tag-field-preview for those fields that provide a string value which should be displayed as single tag (select, radio, toggles)
  • Fixes passing image from pages, files and users field previews
  • Fixes fallback for users field preview if no username is set
  • Replaces deprecated BubblesFieldPreview usage
  • Replaces deprecated bubbles CSS class in k-link-field

Changelog

Fixes

  • Select, radio and toggles field: values that include a comma will not be split into two tags in the structure field preview anymore

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative marked this pull request as ready for review January 23, 2025 16:01
@distantnative distantnative requested a review from a team January 23, 2025 16:01
@bastianallgeier bastianallgeier merged commit 8f83464 into v5/develop Jan 24, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the v5/fix/6939-tags-field-preview branch January 24, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[v5] Field previews: fix tags field preview and related Bubbles field preview always splits on commas
2 participants