Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
The blocks field is currently glitchy when showing the empty placeholder. As it so far relies on
data-empty
attribute, it still gets shown even when a block from another blocks field is moved over (as it technically is only the sortable ghost and not present yet in the blocks data array).This PR tries to solve this rather by utilizing CSS
:empty
and:has()
to decide when the.-k-blocks-list
is truly empty of blocks but also sortable ghosts and spending on that show/hide the empty placeholder.With this change (and the previous sortable change), the ancient #5290 seems to be solved.
Additional context
I didn't run into any errors with this last state. But would feel better if @afbora hits it hard with your bug finding skills.
Changelog
Fixes
Ready?
Unit tests for fixed bug/featureFor review team