Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(revshare): missing bits to complete the feature #3094

Merged
merged 20 commits into from
Jan 23, 2025

Conversation

ancorcruz
Copy link
Contributor

@ancorcruz ancorcruz commented Jan 22, 2025

Roadmap

👉 https://getlago.canny.io/feature-requests/p/calculate-revenue-share

Context

Current problem: companies with partners selling for them cannot have a revenue share system in Lago.

We want to propose self-billing into Lago, a billing arrangement where the customer creates and issues the invoice on behalf of the supplier for goods or services received.

Description

  • exclude self billed invoices in customer overdue balance calculations
  • Add query filters for customer account_type, and invoices and credit notes self_billed
  • Add account_type to graphQL customer portal customer object
  • Add account_type filter to graphql customers resolver and Api endpoint
  • Add self_billed filter to graphql invoices resolver and Api endpoint
  • Add self_billed filter to graphql credit notes resolver and Api endpoint
  • Add self_billed to credit note and fee API serializer
  • Update self_billed pdf invoices translations
  • Adapt template for self_billed one_off invoices

@ancorcruz ancorcruz self-assigned this Jan 22, 2025
extract one_off logic to a partial for re-use
@ancorcruz ancorcruz requested a review from annvelents January 22, 2025 17:15
@ancorcruz ancorcruz changed the title feat(revshare): missing parts to complete the feature dev feat(revshare): missing bits to complete the feature Jan 22, 2025
@ancorcruz ancorcruz marked this pull request as ready for review January 23, 2025 08:04
Copy link
Contributor

@annvelents annvelents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool stuff! 😎

@ancorcruz ancorcruz merged commit bda45af into main Jan 23, 2025
6 checks passed
@ancorcruz ancorcruz deleted the feat/revshare-missing-parts branch January 23, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants