Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Remove filters from credit notes #2003

Merged
merged 2 commits into from
Jan 27, 2025
Merged

hotfix: Remove filters from credit notes #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d3eece
feat(CreditNotesTable): add showFilters prop
stephenlago99 Jan 27, 2025
bffc36f
fix: remove filters from invoice/customer credit notes table
stephenlago99 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions src/components/creditNote/CreditNotesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ type TCreditNoteTableProps = {
variables: LazyQueryHookOptions['variables'] | undefined
customerTimezone?: TimezoneEnum
tableContainerSize?: ResponsiveStyleValue<TableContainerSize>
showFilters?: boolean
}

const CreditNoteTableItemSkeleton = () => {
Expand All @@ -133,6 +134,7 @@ const CreditNotesTable = ({
customerTimezone,
error,
tableContainerSize,
showFilters = true,
}: TCreditNoteTableProps) => {
const { translate } = useInternationalization()
const navigate = useNavigate()
Expand Down Expand Up @@ -174,22 +176,24 @@ const CreditNotesTable = ({

return (
<>
<div className="box-border flex w-full flex-col gap-3 p-4 shadow-b md:px-12 md:py-3">
<Filters.Provider
availableFilters={[
AvailableFiltersEnum.amount,
AvailableFiltersEnum.creditNoteCreditStatus,
AvailableFiltersEnum.currency,
AvailableFiltersEnum.customerExternalId,
AvailableFiltersEnum.invoiceNumber,
AvailableFiltersEnum.issuingDate,
AvailableFiltersEnum.creditNoteReason,
AvailableFiltersEnum.creditNoteRefundStatus,
]}
>
<Filters.Component />
</Filters.Provider>
</div>
{showFilters && (
<div className="box-border flex w-full flex-col gap-3 p-4 shadow-b md:px-12 md:py-3">
<Filters.Provider
availableFilters={[
AvailableFiltersEnum.amount,
AvailableFiltersEnum.creditNoteCreditStatus,
AvailableFiltersEnum.currency,
AvailableFiltersEnum.customerExternalId,
AvailableFiltersEnum.invoiceNumber,
AvailableFiltersEnum.issuingDate,
AvailableFiltersEnum.creditNoteReason,
AvailableFiltersEnum.creditNoteRefundStatus,
]}
>
<Filters.Component />
</Filters.Provider>
</div>
)}

<ScrollContainer
ref={listContainerElementRef}
Expand Down
1 change: 1 addition & 0 deletions src/components/customers/CustomerCreditNotesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export const CustomerCreditNotesList = ({
customerTimezone={customerTimezone}
error={error}
variables={variables}
showFilters={false}
/>
)}
</div>
Expand Down
1 change: 1 addition & 0 deletions src/pages/InvoiceCreditNoteList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ const InvoiceCreditNoteList = () => {
customerTimezone={data?.invoice?.customer.applicableTimezone || TimezoneEnum.TzUtc}
error={error}
variables={variables}
showFilters={false}
/>
)}
</>
Expand Down
Loading