feat: allow to add fee on draft invoices #2004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/invoices/details/InvoiceFeeArrearsDetailsTable.tsx
Outdated
Show resolved
Hide resolved
ansmonjol
force-pushed
the
feat-adjust-zero-fees-qa
branch
2 times, most recently
from
e433c0c to
d1739e5
Compare
ansmonjol
force-pushed
the
feat-adjust-zero-fees-qa
branch
2 times, most recently
from
ea0d6f2 to
c86c9e9
Compare
ansmonjol
force-pushed
the
feat-adjust-zero-fees-qa
branch
from
c86c9e9 to
a4b5f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are currently able to edit a fee on a draft invoice.
It's convenient as all fees (including ones with 0 unit and amount cents) are all created at billing time.
However we recently removed the creation of "0-fees" mostly for performance gain (they were representing a huge amount of the created fees every billing cycle)
Description
This PR does
Better reviewing the 2 commits separately.
Fixes LAGO-694