Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it stands, any project using
lago-python-client
can't upgrade to Pydantic V2 due to version constraints. Fortunately for us, Pydantic V2 ships with V1 to allow for incremental adoption, which allows us to support both V1 and V2 without fundamentally changing the package's code:In addition to this, I changed all the
from pydantic import BaseModel
imports to pull frombase_model
instead.Type of Change
Feature - non-breaking change
Testing
Used
pytest
to run the tests once for each version. To replicate:pip install -e .
pip uninstall pydantic && pip install pydantic==2.6.1