Added comment system plugin mastodoncomments #433
Conversation
|
Ready for another round. |
v8/mastodoncomments/templates/jinja/comments_helper_mastodoncomments.tmpl
Outdated
Show resolved
Hide resolved
|
Changes done, please review. I overhauled the commands for installation a little bit, that's why there are several commits. |
| @@ -0,0 +1,38 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright (c) 2021 Pieter David | |||
There was a problem hiding this comment.
You probably want your name here :)
There was a problem hiding this comment.
Yeah, everybody should know who to blame. :-D
| const MASTODON_ACCOUNT_ID = '109270094542366763' | ||
| const MASTODON_HOST = 'nerdculture.de' |
There was a problem hiding this comment.
Should this be hardcoded here? Where are those .sd.css and .sd.js files used?
There was a problem hiding this comment.
They aren't (anymore). They were the results of my first try using the method by sd.ai (mentioned somewhere as inspiration) but it wasn't indented on responses so I tried Carl Schwan's method. They are more similar than distinct as I learned during integration but hindsight is 20/20. I removed them. Maybe in the future I take another look because I like the automatic loading. I recognize that there are valid use-cases to not load the comments immediately so maybe that should be an option.
|
We are getting closer to an end. Please review. 😄 |
|
Thanks for contributing! |
|
Thanks for all your advice. It was a pleasure. |
No description provided.