Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3126
It is a continuation of getodk/javarosa#469
What has been done to verify that this works as intended?
I tested the attached form.
Why is this the best possible solution? Were any other approaches considered?
It just removes redundant functionality. it is redundant because of getodk/javarosa#469
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
getodk/javarosa#469 with this pr should just fix the issue and nothing else. Testing indexes visible in the audit file would be enough.
Do we need any specific form for testing your changes? If so, please attach one.
I used this one:
test.xml.txt
but any form with regular groups and repeatable groups is fine.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, I thought that we have some samples in the doc that we would need to fix but looks as if I was wrong.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.