When device orientation is changed no changes will happen #248
Conversation
|
@shobhitagarwal1612 @lakshyagupta21 can you please review it |
| android:parentActivityName=".activities.MainActivity"> | ||
| <activity | ||
| android:name=".activities.SendFormsActivity" | ||
| android:configChanges="orientation|screenSize" |
There was a problem hiding this comment.
I think you should highlight this code as so many changes related to the code style, hard for reviewers to find what truly changed.
There was a problem hiding this comment.
That is the reason I added the line in PR template
There was a problem hiding this comment.
Sure, making a self comment in the code base would be better.
There was a problem hiding this comment.
@huangyz0918 like that I made self comments in PR #240 but @shobhitagarwal1612 asked to remove those comments due to code style will not make better
There was a problem hiding this comment.
I mean, making comment in Github review panel.
There was a problem hiding this comment.
@Chromicle I don't know if its the best solution or not, that's the reason I didn't add it in the first place.
It would be helpful if you can go through the pros and cons of using it, and then update your PR description to back up the changes that you had done.
For ref. https://stackoverflow.com/a/7990543
|
@Chromicle Any updates? |
|
I checked it in all ways and updated in PR templete by adding that code there will be no issues which I detected |
|
Please resolve the merge conflicts. |
Yeah, Done @lakshyagupta21 |
ajay-prabhakar
force-pushed
the
searchquery
branch
from
97ac06f to
4df659f
Compare
|
@lakshyagupta21 can you please review this |
Closes #120
Description
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
Stored the value of selectedForms/ selectedInstances in
onSaveInstanceStateand retrieved the values back when activity is recreatedHow does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
When the device orientation is changed while sending forms then he will get the changes directly instead for selecting forms once again
GIF
Checkings
Before submitting this PR, please make sure you have:
./gradlew check codeand confirmed all checks still pass OR confirm CircleCI build passes