This repository has been archived by the owner on Apr 30, 2021. It is now read-only.
Update Travis and Update to Python 3 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pieter Benjamin <[email protected]> Co-authored-by: Shourya Jain <[email protected]>
|
From looking at the log of the deploy stage of this build job that was invoked by this PR though, it does not seem that the artifacts uploaded properly, I think it is because of how travis is configured for the PR job builds. |
|
I am very impressed with the effort y'all have put in here. Thank you! I'll merge to the branch and get this working on master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PieterBenjamin, @shouryaj, and I are addressing issue #36, building off the work of @shouryaj in PR #35.
The travis.yml now uses workspaces and stages to have a build stage where the macOS and Windows executables separately and then a deploy stage where these are zipped with the read me and uploaded to the S3 bucket, including the git hash in the compressed files name.
The generic links to download the binaries are in the README, but feel free to download this specific build's macOS or Windows binaries.
Further, we updated the python version to Python 3.
I made the status badge in the README point to the travis branch temporarily to test it is working.
There is a reference on #36 to fix the windows paths, but we aren't sure exactly what that means of if we've addressed it.