-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated the following chains to safle-vault opBNB, Ronin, Sei Skale - Nebula, Immutable zk-EVM #365
Conversation
Coverage Report (79%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change PR heading
- add names of integrated chains to changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments for some basic changes.
CHANGELOG.md
Outdated
|
||
### 2.9.3 (2024-12-10) | ||
|
||
-Adding new chains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the name of the chains added
sei: { symbol: "SEI", txType: 0 }, | ||
ronin: { symbol: "RON", txType: 0 }, | ||
nebula: { symbol: "sFUEL", txType: 0 }, | ||
immutable: { symbol: "IMX", txType: 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Immutable or Immutable ZK?
.env
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not supposed to be changed in this PR, please raise a separate PR for this. @Husienvora
-Adding new default EVM chains