Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated the following chains to safle-vault opBNB, Ronin, Sei Skale - Nebula, Immutable zk-EVM #365

Conversation

Husienvora
Copy link
Member

-Adding new default EVM chains

@Husienvora Husienvora self-assigned this Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Coverage Report (79%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files78.8969.5890.179.2 
chains94.735010094.73 
   index.js94.735010094.7360
config100100100100 
   index.js100100100100 
constants100100100100 
   index.js100100100100 
constants/responses100100100100 
   index.js100100100100 
lib79.7571.5791.4279.69 
   keyring.js77.3770.291.2277.2753, 70, 80, 84–85, 168–188, 241, 284–294, 371–449, 478, 496–497, 507, 513, 522, 528, 558–567, 572, 586–591, 601, 607, 616, 622, 638, 644, 658–663, 672, 678, 687, 693, 701, 715, 738, 768–781, 871–874, 1085, 1115, 1141–1142, 1161–1278, 1380, 1409–1412, 1436–1438, 1485, 1544–1547, 1575, 1620, 1626
   vault.js92.3883.6792.392.3824, 34, 56–58, 87, 100, 116
utils71.7555.3882.3573.8 
   helper.js71.7555.3882.3573.89–16, 89–99, 132, 155, 167–169, 178–182, 203–205, 232, 250, 268, 335–367

@Husienvora Husienvora linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link
Member

@sshubhamagg sshubhamagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change PR heading
  2. add names of integrated chains to changelog

Copy link
Member

@apoorvq apoorvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for some basic changes.

CHANGELOG.md Outdated

### 2.9.3 (2024-12-10)

-Adding new chains
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the name of the chains added

sei: { symbol: "SEI", txType: 0 },
ronin: { symbol: "RON", txType: 0 },
nebula: { symbol: "sFUEL", txType: 0 },
immutable: { symbol: "IMX", txType: 0 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Immutable or Immutable ZK?

.env Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not supposed to be changed in this PR, please raise a separate PR for this. @Husienvora

@Husienvora Husienvora changed the title adding new chains for default EVM chains Integrated the following chains to safle-vault opBNB, Ronin, Sei Skale - Nebula, Immutable zk-EVM Dec 10, 2024
@sshubhamagg sshubhamagg merged commit ac7ed3d into dev Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain integration - EVM
3 participants