Merge pull request #22 from getsafle/test

Updated sign transaction to use ethereumjs-tx module

CHANGELOG.md

@@ -20,4 +20,9 @@
 ##### Updated 'main' path and Updated signTransaction Method. 
 
 - Updated 'main' path to "src/index.js" .
-- Removed signTransaction() dependency from getFees().
+- Removed signTransaction() dependency from getFees().
+
+### 1.0.1 (2024-02-15)
+
+- Updated sign transaction to use ethereumjs-tx module.
+- Removed unused dependencies.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@getsafle/vault-polygon-zkevm-controller",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Polygon zkEVM controller for Safle Vault",
   "main": "src/index.js",
   "scripts": {
@@ -45,15 +45,14 @@
     "nyc": "^15.0.0"
   },
   "dependencies": {
-    "@ethereumjs/common": "^4.1.0",
-    "@ethereumjs/tx": "^5.1.0",
     "axios": "^1.6.2",
     "bip39": "^3.0.4",
     "browser-passworder": "^2.0.3",
     "crypto-js": "^4.2.0",
     "eth-hd-keyring": "^3.6.0",
     "eth-sig-util": "^3.0.1",
     "eth-simple-keyring": "^4.2.0",
+    "ethereumjs-tx": "^1.3.7",
     "ethereumjs-util": "^7.1.0",
     "hdkey": "^2.0.1",
     "loglevel": "^1.7.1",

src/index.js

@@ -11,8 +11,7 @@ const { normalize: normalizeAddress } = require('eth-sig-util')
 const SimpleKeyring = require('eth-simple-keyring')
 const HdKeyring = require('eth-hd-keyring')
 
-const { LegacyTransaction } = require('@ethereumjs/tx')
-const { Common, Hardfork } = require('@ethereumjs/common')
+const Tx = require('ethereumjs-tx');
 const { bufferToHex } = require('ethereumjs-util')
 
 const axios = require('axios')
@@ -264,17 +263,13 @@ class KeyringController extends EventEmitter {
 
     async signTransaction(rawTx, privateKey) {
 
-        const pkey = Buffer.from(privateKey, 'hex');
-
-        const chainId = rawTx.chainId; 
-
-        const common = Common.custom({ chainId: chainId }, { hardfork: Hardfork.Istanbul })
+        const tx = new Tx(rawTx);
 
-        const tx = LegacyTransaction.fromTxData(rawTx, { common })
+        const pkey = Buffer.from(privateKey, 'hex');
 
-        const signedTransaction = tx.sign(pkey);
+        tx.sign(pkey);
 
-        const signedTx = bufferToHex(signedTransaction.serialize());
+        const signedTx = `0x${tx.serialize().toString('hex')}`;
 
         return signedTx
     }