Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Remove cross compilation in CI, update sentry-native #4427

Merged
merged 18 commits into from
Jan 7, 2025
27 changes: 14 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,11 @@ jobs:
target: ${{ fromJson(needs.build-setup.outputs.targets) }}

name: Build Relay Binary
runs-on: ubuntu-latest
runs-on: |-
${{fromJson('{
"x86_64-unknown-linux-gnu": "ubuntu-20.04",
"aarch64-unknown-linux-gnu": "ubuntu-22.04-arm64-relay"
}')[matrix.target] }}

if: "!startsWith(github.ref, 'refs/heads/release-library/')"

Expand All @@ -241,13 +245,16 @@ jobs:
"x86_64-unknown-linux-gnu": "linux/amd64",
"aarch64-unknown-linux-gnu": "linux/arm64"
}')[matrix.target] }}
# Fix editor: '

steps:
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y llvm
sudo apt-get install -y llvm curl

- name: Install sentry-cli
run: |
curl -sL https://sentry.io/get-cli/ | bash

- uses: actions/checkout@v4
with:
Expand All @@ -258,23 +265,17 @@ jobs:
with:
key: "${{ github.job }}-${{ matrix.target }}-${{ matrix.image_name }}"

- name: Install Cross
# We need a nightly version of cross for `cross-util`.
run: cargo install cross --git https://github.com/cross-rs/cross --rev 085092c

- name: Compile
run: |
export PATH="/home/runner/.cargo/bin/:$PATH"

cross build --release --locked --features "${FEATURES}" --target "${{ matrix.target }}"
cargo build --release --locked --features "${FEATURES}" --target "${{ matrix.target }}"

- name: Split debug info
run: |
llvm-objcopy --only-keep-debug "${RELAY_BIN}"{,.debug}
llvm-objcopy --strip-debug --strip-unneeded "${RELAY_BIN}"
llvm-objcopy --add-gnu-debuglink "${RELAY_BIN}"{.debug,}

cross-util run --target "${{ matrix.target }}" -- "sentry-cli difutil bundle-sources ${RELAY_BIN}.debug"
sentry-cli difutil bundle-sources "${RELAY_BIN}.debug"
zip "${RELAY_BIN}-debug.zip" "${RELAY_BIN}.debug"

- name: Prepare Artifacts
Expand All @@ -301,7 +302,7 @@ jobs:
image_name: ${{ fromJson(needs.build-setup.outputs.image_names) }}

env:
PLATFORMS: "${{ join(fromJSON(needs.build-setup.outputs.platforms), ',') }}"
PLATFORMS: "${{ join(fromJson(needs.build-setup.outputs.platforms), ',') }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOCKER_IMAGE: "ghcr.io/getsentry/${{ matrix.image_name }}"
REVISION: "${{ github.event.pull_request.head.sha || github.sha }}"

Expand Down Expand Up @@ -355,7 +356,7 @@ jobs:

strategy:
matrix:
image_name: [relay] # Don't publish relay-pop (for now)
image_name: ["relay"] # Don't publish relay-pop (for now)

if: ${{ (github.ref_name == 'master') }}

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Internal**:

- Remove the `spool` command from Relay. ([#4423](https://github.com/getsentry/relay/pull/4423))
- Bump `sentry-native` to `0.7.17` and remove cross compilation in CI. ([#4427](https://github.com/getsentry/relay/pull/4427))

## 24.12.1

Expand Down
2 changes: 1 addition & 1 deletion relay-crash/sentry-native
Submodule sentry-native updated 241 files
Loading