feat(kafka): Add better error message #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jan 21, 2025
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, thiserror::Error)] | ||
| #[derive(Debug, thiserror::Error)] |
There was a problem hiding this comment.
Are you removing these bounds for a specific reason?
There was a problem hiding this comment.
They seemed to be unused and caused problems if I want to embed String inside the Kafka error type.
jjbayer
reviewed
Jan 21, 2025
It was to have it in the logs, without having to go on Sentry (easier for SREs). |
jjbayer
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a better error message for Kafka failures.
#skip-changelog