feat(server): Add option to drop transaction attachments #4466
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Jan 22, 2025
Dav1dde
approved these changes
Jan 22, 2025
Dav1dde
reviewed
Jan 22, 2025
| @@ -1757,7 +1760,6 @@ impl EnvelopeProcessorService { | |||
| // | |||
| // Unconditionally scrub to make sure PII is removed as early as possible. | |||
| event::scrub(&mut event, project_info.clone())?; | |||
| attachment::scrub(managed_envelope, project_info.clone()); | |||
There was a problem hiding this comment.
I think we need to keep this in until the option is removed and attachments are always removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare the simplification of Kafka consumers, stop ingesting attachments that come with transactions.
ref: https://github.com/getsentry/team-ingest/issues/607