-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ourlogs): Preliminary breadcrumb to log conversion #4479
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
use relay_protocol::{Annotated, Empty, FromValue, IntoValue, Object, Value}; | ||
|
||
use crate::processor::ProcessValue; | ||
|
||
/// Our Logs context. | ||
/// | ||
/// The Sentry Logs context contains information about our logging product (ourlogs) for an event. | ||
#[derive(Clone, Debug, Default, PartialEq, Empty, FromValue, IntoValue, ProcessValue)] | ||
pub struct OurLogsContext { | ||
/// Whether breadcrumbs are being deduplicated. | ||
pub deduplicated_breadcrumbs: Annotated<bool>, | ||
|
||
/// Additional arbitrary fields for forwards compatibility. | ||
#[metastructure(additional_properties, retain = true)] | ||
pub other: Object<Value>, | ||
} | ||
|
||
impl super::DefaultContext for OurLogsContext { | ||
fn default_key() -> &'static str { | ||
"sentry_logs" // Ourlogs is an internal name, and 'logs' likely has conflicts with user contexts. | ||
} | ||
|
||
fn from_context(context: super::Context) -> Option<Self> { | ||
match context { | ||
super::Context::OurLogs(c) => Some(*c), | ||
_ => None, | ||
} | ||
} | ||
|
||
fn cast(context: &super::Context) -> Option<&Self> { | ||
match context { | ||
super::Context::OurLogs(c) => Some(c), | ||
_ => None, | ||
} | ||
} | ||
|
||
fn cast_mut(context: &mut super::Context) -> Option<&mut Self> { | ||
match context { | ||
super::Context::OurLogs(c) => Some(c), | ||
_ => None, | ||
} | ||
} | ||
|
||
fn into_context(self) -> super::Context { | ||
super::Context::OurLogs(Box::new(self)) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
use crate::protocol::Context; | ||
|
||
#[test] | ||
fn test_our_logs_context() { | ||
let json = r#"{ | ||
"deduplicated_breadcrumbs": true, | ||
"type": "sentry_logs" | ||
}"#; | ||
let context = Annotated::new(Context::OurLogs(Box::new(OurLogsContext { | ||
deduplicated_breadcrumbs: Annotated::new(true), | ||
..OurLogsContext::default() | ||
}))); | ||
|
||
assert_eq!(context, Annotated::from_json(json).unwrap()); | ||
assert_eq!(json, context.to_json_pretty().unwrap()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these hard to remove later or is the deprecation sticky? If they are I'm probably going to delay this a week until Abhi is back and we can make sure everyone is fine with the context on the sdk side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the variant from the code is not a problem. After removing it, relay will still forward the context as if it were a user-defined context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great