Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(relay): set size limit for user report attachments #4482

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix(relay): set size limit for user report attachments #4482

merged 2 commits into from
Jan 31, 2025
+2 −2

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Jan 31, 2025 •
edited
Loading

This PR introduces a limit for UserReport attachments. Without the limit, the user report will be dropped by the kafka consumer due to limits imposed on the topic.

Fixes RELAY-2P0Z

@Litarnus Litarnus marked this pull request as ready for review January 31, 2025 11:15
Dav1dde
Dav1dde approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should note this in the changelog

@Litarnus Litarnus requested a review from a team as a code owner January 31, 2025 11:15
@Litarnus Litarnus merged commit bbf56dd into master Jan 31, 2025
26 checks passed
@Litarnus Litarnus deleted the martinl/set-user-report-size branch January 31, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-wilfert tobias-wilfert tobias-wilfert approved these changes

@jjbayer jjbayer jjbayer approved these changes

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Litarnus @Dav1dde @jjbayer @tobias-wilfert