fix(pii): prevent ip derivation if already scrubbed before #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
Feb 11, 2025
jjbayer
reviewed
Feb 11, 2025
loewenheim
reviewed
Feb 11, 2025
| .any(|r| r.ty == RemarkType::Removed); | ||
| if !scrubbed_before { | ||
| // In an ideal world all SDKs would set {{auto}} explicitly. | ||
| if let Some("javascript") | Some("cocoa") | Some("objc") = platform { |
There was a problem hiding this comment.
I don't think I've ever seen if let used with this sort of pattern before.
There was a problem hiding this comment.
Me neither, but I like its expressiveness
jjbayer
approved these changes
Feb 11, 2025
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds remarks if the user IP was PII scrubbed to prevent assuming that empty IP means
{{auto}}for certain platforms.fix #4480