Skip to content

ref(rrweb): WIP: refactor sideeffects from rrweb/record #1358

ref(rrweb): WIP: refactor sideeffects from rrweb/record

ref(rrweb): WIP: refactor sideeffects from rrweb/record #1358

Triggered via pull request January 23, 2025 19:30
@billyvgbillyvg
opened #236
Status Failure
Total duration 8m 6s
Artifacts

style-check.yml

on: pull_request_target
ESLint Check and Report Upload
7m 56s
ESLint Check and Report Upload
ESLint Annotation
0s
ESLint Annotation
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 12 warnings
ESLint Check and Report Upload: packages/rrweb/src/record/index.ts#L716
ES2015 module syntax is preferred over namespaces
ESLint Check and Report Upload: packages/rrweb/src/record/index.ts#L717
Unexpected var, use let or const instead
ESLint Check and Report Upload
@sentry-internal/rrweb#lint: command (/home/runner/work/rrweb/rrweb/packages/rrweb) /tmp/yarn--1737661050475-0.9434704852219782/yarn run lint exited (1)
ESLint Check and Report Upload
Process completed with exit code 1.
Format Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ESLint Check and Report Upload
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ESLint Check and Report Upload: packages/rrweb/src/record/index.ts#L615
Forbidden non-null assertion
ESLint Check and Report Upload: packages/rrweb/src/record/index.ts#L633
Forbidden non-null assertion
ESLint Check and Report Upload: packages/rrweb/src/record/observer.ts#L1281
'_hooks' is assigned a value but never used
ESLint Check and Report Upload: packages/rrweb/src/replay/canvas/deserialize-args.ts#L9
Unexpected any. Specify a different type