enh: propagate sample seed in baggage #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3f3ef0b | 1223.73 ms | 1237.67 ms | 13.94 ms |
| 3a43905 | 1254.31 ms | 1266.35 ms | 12.04 ms |
| 895becc | 1288.00 ms | 1308.63 ms | 20.63 ms |
| 3f23617 | 1261.93 ms | 1286.10 ms | 24.17 ms |
| 6aab859 | 1245.14 ms | 1247.59 ms | 2.45 ms |
| 2d74010 | 1264.45 ms | 1268.42 ms | 3.97 ms |
| b98109e | 1254.19 ms | 1279.90 ms | 25.71 ms |
| 95c69e3 | 1223.94 ms | 1245.29 ms | 21.35 ms |
| e3d9076 | 1203.68 ms | 1230.65 ms | 26.97 ms |
| 8cb6557 | 1265.14 ms | 1266.08 ms | 0.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3f3ef0b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 3a43905 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 895becc | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 3f23617 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 6aab859 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 2d74010 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| b98109e | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| 95c69e3 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| e3d9076 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 8cb6557 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
| 039058a | 448.52 ms | 512.55 ms | 64.03 ms |
| 3a43905 | 334.12 ms | 404.02 ms | 69.90 ms |
| ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
| 0095354 | 511.17 ms | 549.12 ms | 37.96 ms |
| f7f46dc | 306.38 ms | 363.32 ms | 56.95 ms |
| d61cecf | 339.69 ms | 387.57 ms | 47.88 ms |
| 895becc | 326.94 ms | 376.02 ms | 49.08 ms |
| 521cfbf | 332.78 ms | 376.04 ms | 43.26 ms |
| 03e4c9b | 410.34 ms | 493.20 ms | 82.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
| 039058a | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 3a43905 | 6.06 MiB | 7.03 MiB | 996.98 KiB |
| ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 0095354 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| f7f46dc | 6.06 MiB | 7.03 MiB | 993.54 KiB |
| d61cecf | 6.06 MiB | 7.03 MiB | 995.56 KiB |
| 895becc | 6.06 MiB | 7.03 MiB | 997.23 KiB |
| 521cfbf | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| 03e4c9b | 6.35 MiB | 7.42 MiB | 1.07 MiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2629 +/- ##
===========================================
+ Coverage 74.04% 89.13% +15.08%
===========================================
Files 28 263 +235
Lines 1025 8964 +7939
===========================================
+ Hits 759 7990 +7231
- Misses 266 974 +708 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Propagates the seed used for sampling in traces to improve on distributed tracing
💡 Motivation and Context
Closes #2559
💚 How did you test it?
Unit test, manual checking of headers
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps