[v9]: Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
reviewed
Jan 29, 2025
# Conflicts: # .github/workflows/dart.yml # dart/test/run_zoned_guarded_integration_test.dart # flutter/lib/src/sentry_asset_bundle.dart # flutter/lib/src/sentry_flutter.dart # flutter/test/screenshot/sentry_screenshot_widget_test.dart
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -393,6 +393,10 @@ | |||
| - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#7181) | |||
| - [diff](https://github.com/getsentry/sentry-java/compare/7.18.0...7.18.1) | |||
|
|
|||
| ## 9.0.0 | |||
|
|
|||
| - Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) | |||
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 8.13.0.
Consider moving the entry to the## Unreleasedsection, please.
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
buenaflor
reviewed
Jan 29, 2025
buenaflor
reviewed
Jan 30, 2025
vaind
requested changes
Jan 30, 2025
| @@ -869,7 +869,7 @@ class SentryNative { | |||
| /// frozen but lists and dicts are not and can be frozen on demand. This | |||
| /// automatically happens for some shared values in the event payload like | |||
| /// the module list. | |||
| class sentry_value_u extends ffi.Union { | |||
| base class sentry_value_u extends ffi.Union { | |||
There was a problem hiding this comment.
these should be final class, see
There was a problem hiding this comment.
Also can you please update the script?
| @@ -31229,13 +31229,13 @@ class NSObject extends _ObjCWrapper { | |||
| } | |||
| } | |||
|
|
|||
| class ObjCSel extends ffi.Opaque {} | |||
| base class ObjCSel extends ffi.Opaque {} | |||
There was a problem hiding this comment.
these should be final class, see
There was a problem hiding this comment.
Also can you please update the script?
|
You can also get rid of this compatibility code: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #2626
💚 How did you test it?
CI
📝 Checklist
sendDefaultPiiis enabled