Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Remove old user feedback api #2686

Merged
merged 14 commits into from
Feb 18, 2025
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

💡 Motivation and Context

Closes #2682

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the base branch from main to v9 February 10, 2025 23:19
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (ea071ab) to head (619c6a2).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2686      +/-   ##
==========================================
+ Coverage   88.24%   88.37%   +0.12%     
==========================================
  Files         263      262       -1     
  Lines        8918     8862      -56     
==========================================
- Hits         7870     7832      -38     
+ Misses       1048     1030      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor
Copy link
Contributor Author

@denrase I updated the hive mocks with the build_runner but now the hive tests are failing because something's wrong with the generated mocks, have you encountered this as well?

@denrase
Copy link
Collaborator

denrase commented Feb 11, 2025

@buenaflor Yup, had the same issue yesterday, just check my commits here: https://github.com/getsentry/sentry-dart/pull/2675/commits

@buenaflor
Copy link
Contributor Author

@denrase how did you fix it? re-generating the mock doesn't seem to work in my case

@denrase
Copy link
Collaborator

denrase commented Feb 11, 2025

@buenaflor Added the compiler directives back in that were deleted (see diff or commits) and also in hive mocks, there is some custom code which i added back in after re-generation overrode it.

60a3c2a

@buenaflor buenaflor requested a review from denrase February 12, 2025 16:38
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buenaflor Analyze is failing, probably just some warning left somewhere.

dart/lib/src/sentry_envelope_item.dart Show resolved Hide resolved
isar/test/mocks/mocks.mocks.dart Show resolved Hide resolved
@buenaflor buenaflor merged commit 65d5fea into v9 Feb 18, 2025
153 checks passed
@buenaflor buenaflor deleted the v9-task/remove-old-user-feedback branch February 18, 2025 09:25
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9]: Remove old feedback API
2 participants