Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hint in test #2739

Closed
wants to merge 4 commits into from
Closed

Add missing hint in test #2739

wants to merge 4 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 20, 2025

#skip-changelog

Fix test

@denrase denrase marked this pull request as ready for review February 20, 2025 15:31
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (0f8bd48) to head (64595fc).

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2739      +/-   ##
==========================================
+ Coverage   87.16%   89.73%   +2.57%     
==========================================
  Files         175       91      -84     
  Lines        5966     2952    -3014     
==========================================
- Hits         5200     2649    -2551     
+ Misses        766      303     -463     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor
Copy link
Contributor

buenaflor commented Feb 20, 2025

@denrase I fixed the mocks in temp/8.13.2 branch, we'll have to re-generate the mocks here because the newest Flutter version isn't compatible anymore with those

@buenaflor
Copy link
Contributor

I fixed the mocks and test directly in the v9 branch during merging main

@buenaflor buenaflor closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants