Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flutter runtime information #2742

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Feb 20, 2025

📜 Description

Fun fact: This fixes the oldest currently open issue

💡 Motivation and Context

#416

💚 How did you test it?

I'm not entirely sure how to test this, since Dart defines aren't mockable

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Wait until the Flutter PR is merged, then merge this.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (ea1d45d) to head (ce305a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/event_processor/enricher/flutter_runtime.dart 25.00% 3 Missing ⚠️
...rocessor/enricher/io_enricher_event_processor.dart 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   88.99%   88.95%   -0.04%     
==========================================
  Files         263      264       +1     
  Lines        8923     8930       +7     
==========================================
+ Hits         7941     7944       +3     
- Misses        982      986       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ueman ueman marked this pull request as ready for review February 20, 2025 17:48
@buenaflor
Copy link
Contributor

ohh nice! 🥳

@ueman ueman marked this pull request as draft February 20, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report version of Flutter
2 participants