Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GLAD-L column names; fixes GTC-2509 #177

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

solomon-negusse
Copy link

Copy link
Contributor

@tiagojsag tiagojsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

@solomon-negusse
Copy link
Author

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

Hm, it didn't look like the field was used from the response. Checking if I missed that..

@solomon-negusse
Copy link
Author

Have you tested the query response handling code? If a column name changes, not only do you need to modify the query, but also the logic that handles its response.

@tiagojsag: type hints and unit tests are updated with the field name change. may have to sync with you or let me know here if there's any more update I missed.

@solomon-negusse solomon-negusse changed the base branch from dev to staging September 28, 2023 15:35
@solomon-negusse solomon-negusse mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants