CPU/CUDA: fix GQA mul mat back, add CUDA support #11380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master the backward pass for matrix multiplication does not work correctly when the broadcasting for GQA is involved. However, this is not being detected because all of the relevant gradient tests are being skipped for speed. This PR fixes the backward pass and adds CUDA support. To make the backward pass work I am adding an extra parameter to
ggml_repeat_back
because the GQA broadcasting is different from e.g. the one inggml_repeat
.This PR also adds minor fixes to other backward passes. After this PR it should not be necessary to make further changes to ggml ops for #10544 .