Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic filters from OneTrust CMP detection #196

Closed
wants to merge 1 commit into from

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Jan 4, 2024

Exception rules were pushed to Ghostery filters (adblocker-filters) but the origin is at TrackerDB.

I don't know removing these rules is a good step for TrackerDB because they're required to detect OneTrust CMPs.

@seia-soto seia-soto marked this pull request as draft January 4, 2024 09:14
@philipp-classen
Copy link
Member

Exception rules were pushed to Ghostery filters (adblocker-filters) but the origin is at TrackerDB.

I don't know removing these rules is a good step for TrackerDB because they're required to detect OneTrust CMPs.

As I understand, the goal is have the rules disabled for NeverConsent. The override to disable them was originally only in adblocker-filters, but when we switched to TrackerDB, they were add to TrackerDB. From that point on the overrides in adblocker filters were no longer needed.

Note that the PR currently would have the opposite effect. Both for detection and whitelisting, having them only in TrackerDB looks best. And in adblocker-filters, we could remove them, since the (negated) rules there should be redundant then.

@seia-soto
Copy link
Member Author

Totally agree. That's the point I wanted to say.

@seia-soto seia-soto closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants