-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use default assignee only if category is not specified or it doesn't have a default assignee itself #33
use default assignee only if category is not specified or it doesn't have a default assignee itself #33
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# ide files | ||
.idea |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,8 @@ en: | |
interactive_assignment_explanation: > | ||
When creating a new issue, the plugin can populate the assignee with the | ||
default assignee you've chosen above, so that it'll be visible even before | ||
you've created the issue. However, when you change certain fields, the form | ||
you've created the issue. It works only if Override Category Assignee is enabled. | ||
However, when you change certain fields, the form | ||
is reloaded and the default assignee is recalculated. This might be what you | ||
want, or it might be undesirable, so you can make the choice yourself: | ||
interactive_assignment: "Set Assignee Interactively" | ||
|
@@ -18,3 +19,6 @@ en: | |
assignee set, tick the box below to assign the issue to the user who just | ||
created the issue, if possible. If the box is left unticked, there will be | ||
no assignee, which is the default behaviour in Redmine. | ||
default_assign: | ||
override_category_assignee_info: "Override Category Assignee" | ||
override_category_assignee: "Override Category Assignee" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add these keys to the other translation files as well? A copy of the English versions will do fine until someone submits a translation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You might need to add a sentence in English to the end of whatever they have for the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,9 @@ def view_issues_form_details_top(context = {}) | |
interactive_assignment = | ||
Setting.plugin_redmine_default_assign['interactive_assignment'] || 'true' | ||
interactive_assignment = (interactive_assignment == 'true') | ||
return if not interactive_assignment | ||
return if !interactive_assignment | ||
# if interactive_assignment is true don't do anything if 'override category assignee' is false | ||
return if Setting.plugin_redmine_default_assign[:override_category_assignee] != 'true' | ||
|
||
if context[:project].default_assignee.blank? | ||
self_assignment = | ||
|
@@ -22,5 +24,5 @@ def view_issues_form_details_top(context = {}) | |
end | ||
|
||
nil | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what's going on there. Is that a trailing space, maybe? |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering why the indentation has changed here? Looks like it might have gained a space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that 2 spaces indentation is a ruby best practice
https://github.com/bbatsov/ruby-style-guide#source-code-layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, was there only 1 previously? If so, could you re-indent the whole file a separate commit, so that the code changes don't get lost in the whitespace change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I'm sorry I'm hurry