Fixes #702: Resolve TypeError in mapper_quickstart.ipynb
tutorial notebook
#708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This pull request addresses the issue reported in Issue #702 regarding an error encountered when executing the
mapper_quickstart.ipynb
notebook. The error resulted from compatibility issues betweenscikit-learn
version 1.5.2 and thegiotto-tda
library.Problem Statement
The user reported errors stemming from the following snippet in the notebook:
The detailed traceback indicated a
TypeError
due to changes in thescikit-learn
API that have not been reflected in theListFeatureUnion
class withingiotto-tda
. The main consequence is an inability to use the notebook seamlessly under the current library conditions.Actions Taken
Short-term Fix
scikit-learn
from version 1.5.2 to 1.3.2, which resolves the immediate error and allows the tutorial to function correctly withgiotto-tda
version 0.6.2.Long-term Recommendations
To ensure ongoing compatibility with future versions of
scikit-learn
, it is recommended that theListFeatureUnion
class ingiotto-tda
be updated. The key changes should include:_parallel_func
method.scikit-learn 1.5.2
.User Guidance
giotto-tda
andscikit-learn 1.3.2
to work through the tutorial notebooks, while maintaining their main environment with the updated version ofscikit-learn
.Conclusion
The applied short-term fix enables users to proceed with tutorial usage without encountering errors. Attention from the maintainers is required for long-term updates to ensure compatibility with upcoming changes in
scikit-learn
.Fixes #702