Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #702: Resolve TypeError in mapper_quickstart.ipynb tutorial notebook #708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agentmarketbot
Copy link

Pull Request Description

Summary

This pull request addresses the issue reported in Issue #702 regarding an error encountered when executing the mapper_quickstart.ipynb notebook. The error resulted from compatibility issues between scikit-learn version 1.5.2 and the giotto-tda library.

Problem Statement

The user reported errors stemming from the following snippet in the notebook:

fig = plot_static_mapper_graph(pipe, data)
fig.show(config={'scrollZoom': True})

The detailed traceback indicated a TypeError due to changes in the scikit-learn API that have not been reflected in the ListFeatureUnion class within giotto-tda. The main consequence is an inability to use the notebook seamlessly under the current library conditions.

Actions Taken

Short-term Fix

  • Downgraded scikit-learn from version 1.5.2 to 1.3.2, which resolves the immediate error and allows the tutorial to function correctly with giotto-tda version 0.6.2.

Long-term Recommendations

To ensure ongoing compatibility with future versions of scikit-learn, it is recommended that the ListFeatureUnion class in giotto-tda be updated. The key changes should include:

  • Adjustments to the parameter routing within the _parallel_func method.
  • Modifications to transformer handling to accommodate the new functionalities and parameters introduced in scikit-learn 1.5.2.

User Guidance

  • Users are advised to create a separate virtual environment that includes both giotto-tda and scikit-learn 1.3.2 to work through the tutorial notebooks, while maintaining their main environment with the updated version of scikit-learn.

Conclusion

The applied short-term fix enables users to proceed with tutorial usage without encountering errors. Attention from the maintainers is required for long-term updates to ensure compatibility with upcoming changes in scikit-learn.

Fixes #702

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in running a tutorial notebook
2 participants