Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderizar error en HTML cuando falla la previsualización del cuerpo del mail desde el asistente de previsualizar correo #162

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

lcbautista
Copy link
Member

@lcbautista lcbautista commented Jul 16, 2024

Comportamiento antiguo

El error que se muestra en la plantilla es el siguiente (por ejemplo):

imagen

Comportamiento nuevo

El error ahora se renderiza y permite encontrar de manera más rápida que está fallando:

imagen

Que visualmente en un visualizador HTML:

imagen

@lcbautista lcbautista self-assigned this Jul 16, 2024
@lcbautista lcbautista force-pushed the 59452_imp_render_error_wizard_preview_mail branch from e87c47f to 490e6e0 Compare July 16, 2024 07:55
@lcbautista lcbautista requested a review from AdriaGual July 16, 2024 07:55
@lcbautista lcbautista enabled auto-merge July 16, 2024 07:56
Copy link
Contributor

@AdriaGual AdriaGual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

PY3TestsResults

76 tests   76 ✅  1m 45s ⏱️
 2 suites   0 💤
 2 files     0 ❌

Results for commit 490e6e0.

Copy link

PY2TestsResults

76 tests   76 ✅  1m 48s ⏱️
 2 suites   0 💤
 2 files     0 ❌

Results for commit 490e6e0.

@lcbautista lcbautista merged commit 75fed03 into v5_backport Jul 16, 2024
5 checks passed
@lcbautista lcbautista deleted the 59452_imp_render_error_wizard_preview_mail branch July 16, 2024 08:09
@lcbautista lcbautista temporarily deployed to gisceerppre July 16, 2024 08:15 Inactive
@lcbautista lcbautista temporarily deployed to frankenergie-pre July 17, 2024 13:07 Inactive
@lcbautista lcbautista had a problem deploying to frankenergie-pre July 17, 2024 15:49 Error
@lcbautista lcbautista had a problem deploying to frankenergie-erp July 17, 2024 15:50 Error
@lcbautista lcbautista temporarily deployed to frankenergie-erp July 17, 2024 15:53 Inactive
@davidrabassa davidrabassa had a problem deploying to gisceerppre July 22, 2024 08:14 Error
@joanperez1 joanperez1 had a problem deploying to gisceerppre July 22, 2024 08:16 Error
@davidrabassa davidrabassa had a problem deploying to gisceerppre July 22, 2024 08:19 Error
@davidrabassa davidrabassa had a problem deploying to gisceerppre July 22, 2024 08:20 Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants