This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
update Electron and some other dependencies #30
Merged
johndbritton
merged 26 commits into
github-education-resources:master
from
shiftkey:refresh-codebase
Mar 28, 2018
Merged
update Electron and some other dependencies #30
johndbritton
merged 26 commits into
github-education-resources:master
from
shiftkey:refresh-codebase
Mar 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than drag this massive PR out further, I've opened up issues to address the remaining work that I'm not sure about. @johndbritton I don't seem to have the magic merge button - would you mind doing the honours? |
@shiftkey merged, also giving you access to merge your own pull requests now. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're probably wondering what I'm doing here. @johndbritton was looking for someone with Electron experience to help out with supporting this app and helping to get new features in. I work on the Desktop team at GitHub, so I figure I'd be able to help out.
Also, fair warning: I've not used the Classroom app before this, so it'd be great to get some help to confirm I haven't broken anything in here as I've been tidying up.
So, what have I done?
.npmrc
file at the root of the repository, and should be bumped in time with Electronelectron-mocha
instead ofjest
- Jest is cool, but the clone tests usingnodegit
should be run within an Electron app, andelectron-mocha
is designed for just that. I couldn't find an equivalent test framework for Jest to do this that was well-supported, but most of the remaining changes were around assertions.recompose
, but I think it's fine here to just write some plain React components and 🔥 that dependencyreact-spinjs
forreact-spinners
-react-spinjs
hasn't been updated in ~2yrs, so I just switched it over to something better supported. There's probably some styling issues here, as I wasn't sure how to trigger it and see the animation, but we can deal with that later.TODO
[ ] there's one more test (currently skipped) that relies on nested actions - it'd be nice to get that working but I'm not sure how to spy on the actions sent when they're nested in this waymoved to investigate enabling submission-clone-all-test #34[ ] we're currently running an old version ofmoved to upgrade react-router to v4 #33react-router
- I'm not familiar with how to migrate fully, but it seems to work and I'm okay with punting that work to later because the migration path seem complex.[ ] cloning the default values requires credentials - does the app need to auth and store a token to track that?moved to cloning repository requires token (and OAuth app?) #32[ ] Electrons applications now need to be signed on macOS to update correctly, so the updater generates an error at runtimemoved to setup codesigning and create new release #31