Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock on Merge branch check improvements #344

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

GrantBirki
Copy link
Member

This pull request does the following:

  • Checks for lock branches before checking for lock files. This is the default behavior else where, so the same should be done in the "unlock on merge" workflow
  • Adds colored logs to the "unlock on merge" workflow to make it easier to read

@GrantBirki GrantBirki self-assigned this Dec 14, 2024
@Copilot Copilot bot review requested due to automatic review settings December 14, 2024 07:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/functions/unlock-on-merge.js:41

  • [nitpick] The error message 'no lock branch found' should be more descriptive to provide better context, e.g., 'No lock branch found for the specified environment.'
core.info(`⏩ no lock branch found for environment ${COLORS.highlight}${environment}${COLORS.reset} - skipping...`)

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@GrantBirki GrantBirki merged commit 3d4735a into main Dec 14, 2024
4 checks passed
@GrantBirki GrantBirki deleted the unlock-on-merge-improvements branch December 14, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant