Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve commit verification failure text #346

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

GrantBirki
Copy link
Member

This pull request updates the text that gets returned when a commit verification fails. In most cases, where these checks fail, it is because the commit and the .deploy comment occurred at nearly the same time.

@GrantBirki GrantBirki self-assigned this Dec 16, 2024
@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 18:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/functions/commit-safety-checks.js:62

  • The updated error message is clear and provides actionable feedback. No issues found.
message: `### ⚠️ Cannot proceed with deployment\n\nThe latest commit is not safe for deployment. The commit signature was verified after the trigger comment was created. Please try again if you recently pushed a new commit.`

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@GrantBirki GrantBirki merged commit a6f4541 into main Dec 16, 2024
4 checks passed
@GrantBirki GrantBirki deleted the commit-verification-text-update branch December 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant