Skip to content

Commit

Permalink
java: remove the 2 from SafeTransformerFactoryFlow, not that the …
Browse files Browse the repository at this point in the history
…previous naming conflict has been deleted
  • Loading branch information
erik-krogh committed Jan 28, 2025
1 parent a1afa20 commit c7fc164
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions java/ql/lib/semmle/code/java/security/XmlParsers.qll
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ class TransformerFactorySource extends XmlParserCall {
override Expr getSink() { result = this.getArgument(0) }

override predicate isSafe() {
SafeTransformerFactoryFlow2::flowsTo(DataFlow::exprNode(this.getQualifier()))
SafeTransformerFactoryFlow::flowsTo(DataFlow::exprNode(this.getQualifier()))
}
}

Expand All @@ -803,7 +803,7 @@ private predicate safeTransformerFactoryNode(DataFlow::Node src) {
src.asExpr() instanceof SafeTransformerFactory
}

private module SafeTransformerFactoryFlow2 = DataFlow::SimpleGlobal<safeTransformerFactoryNode/1>;
private module SafeTransformerFactoryFlow = DataFlow::SimpleGlobal<safeTransformerFactoryNode/1>;

/** A safely configured `TransformerFactory`. */
class SafeTransformerFactory extends VarAccess {
Expand All @@ -826,7 +826,7 @@ class SafeTransformer extends MethodCall {
this.getMethod() = m and
m.getDeclaringType() instanceof TransformerFactory and
m.hasName("newTransformer") and
SafeTransformerFactoryFlow2::flowsTo(DataFlow::exprNode(this.getQualifier()))
SafeTransformerFactoryFlow::flowsTo(DataFlow::exprNode(this.getQualifier()))
)
}
}
Expand All @@ -849,7 +849,7 @@ class SaxTransformerFactoryNewXmlFilter extends XmlParserCall {
override Expr getSink() { result = this.getArgument(0) }

override predicate isSafe() {
SafeTransformerFactoryFlow2::flowsTo(DataFlow::exprNode(this.getQualifier()))
SafeTransformerFactoryFlow::flowsTo(DataFlow::exprNode(this.getQualifier()))
}
}

Expand Down

0 comments on commit c7fc164

Please sign in to comment.