C++: Support concept id expressions #18366
Open
+10,906
−1,107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
jketema/template-parameters-4
branch
4 times, most recently
from
c843bfa to
0f5b70a
Compare
jketema
force-pushed
the
jketema/template-parameters-5
branch
from
0a8643e to
a4e7505
Compare
If a type would be used in multiple places in the AST, rendering of the AST would be broken. Hence, we cannot directly use types as AST nodes.
jketema
force-pushed
the
jketema/template-parameters-5
branch
from
a4e7505 to
94dabbc
Compare
jketema
commented
Jan 7, 2025
|
|
||
| private Type getTemplateArgumentType(int index) { | ||
| exists(int i | if this.isTypeConstraint() then i = index - 1 else i = index | | ||
| concept_template_argument(underlyingElement(this), i, unresolveElement(result)) |
There was a problem hiding this comment.
Note that there's a trade-off in the design here: I follow what we do for the arguments in template instantiations, as concept ids are similar to those. Alternatively we could have added them as a kind of child expressions. The latter would have made the modifications to PrintAST somewhat simpler, but would have required custom code on the extractor-side, while in the current situation that shares code with template instantiations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).