Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Change source generated razor file paths to be relative to csproj #18407

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C# label Jan 6, 2025
Comment on lines +48 to +52
catch (Exception e)
{
logger.LogWarning($"Failed to get relative path for {cshtml}: {e.Message}");
relativePath = adjustedPath;
}

Check notice

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.
@tamasvajk tamasvajk force-pushed the fix/razor-relative-path branch from 38c3ec2 to c9fab0b Compare January 6, 2025 10:10
@tamasvajk tamasvajk marked this pull request as ready for review January 6, 2025 10:41
@tamasvajk tamasvajk requested a review from a team as a code owner January 6, 2025 10:41
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamasvajk tamasvajk merged commit e67f4be into github:main Jan 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants