JS: Fix a few perf issues #18412
Merged
JS: Fix a few perf issues #18412
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
changed the title
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/ExceptionXssQuery.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/UnvalidatedDynamicMethodCallCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/UnvalidatedDynamicMethodCallQuery.qll: Language not supported
- javascript/ql/src/Security/CWE-915/PrototypePollutingFunction.ql: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some performance issues uncovered in the recent QA run, by restricting sinks and steps, and in some cases the maximum AP length. This fixes the 4 worst regressions in the QA run.
Evaluation also reflects the performance improvements, with a nice 3% speedup on average, 1% median, 33% on vscode and 20% on amphtml. No change in results were observed.
Also contains a drive-by fix for hiding a node that should be hidden.