Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to default inputs #139

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fall back to default inputs #139

merged 1 commit into from
Jan 7, 2025

Conversation

ncalteen
Copy link
Collaborator

@ncalteen ncalteen commented Jan 7, 2025

This PR adds a check so that, if an input is not present in the environment variables, the default value is used from the action.yml/action.yaml file (if a default is present).

@ncalteen ncalteen self-assigned this Jan 7, 2025
@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 22:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/stubs/core/core.ts:282

  • Add a test case to verify that the default value for boolean inputs is correctly interpreted as a boolean.
input = EnvMeta.inputs[name].default.trim()

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link

github-actions bot commented Jan 7, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.05s
✅ JAVASCRIPT prettier 11 0 1.36s
✅ JSON jsonlint 23 0 0.42s
✅ JSON npm-package-json-lint yes no 0.86s
✅ JSON prettier 23 0 3.76s
✅ MARKDOWN markdownlint 8 0 0.88s
✅ REPOSITORY checkov yes no 20.72s
✅ REPOSITORY gitleaks yes no 1.1s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY grype yes no 20.78s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy yes no 10.77s
✅ REPOSITORY trivy-sbom yes no 1.06s
✅ REPOSITORY trufflehog yes no 28.97s
✅ TYPESCRIPT prettier 60 0 4.67s
✅ YAML prettier 21 0 1.93s
✅ YAML yamllint 21 0 1.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen ncalteen merged commit 268ee33 into main Jan 7, 2025
4 checks passed
@ncalteen ncalteen deleted the ncalteen/inputs branch January 7, 2025 22:13
@ncalteen ncalteen mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant