Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(README.md, 7-create-environment.md), build(main.bicep): fix, add, fix #10

Closed
wants to merge 7 commits into from
Closed

docs(README.md, 7-create-environment.md), build(main.bicep): fix, add, fix #10

wants to merge 7 commits into from

Conversation

lloydchang
Copy link
Contributor

@lloydchang lloydchang commented Oct 21, 2023 •
edited
Loading

  • fix docs(README.md) display error message, Not Found
  • add docs(7-create-environment.md): add: Debugging the workflow
  • fix build(main.bicep): fix 'containerapps' 'cpu' expects 'int | null'

@lloydchang
Copy link
Contributor Author

Hi @GeekTrainer, I believe this pull request fixes the README.md display error message,Not Found, that we experienced during Streamline coding with GitHub with Christopher Harrison. Thank you!

@lloydchang lloydchang changed the title docs(README.md): fix relative link docs(README.md, 7-create-environment.md): fix, add Oct 22, 2023
@lloydchang lloydchang changed the title docs(README.md, 7-create-environment.md): fix, add docs(README.md, 7-create-environment.md), build(main.bicep): fix, add, fix Oct 22, 2023
@lloydchang
Copy link
Contributor Author

I've split these changes into 3 new PRs #11, #12, and #13. Hence closing this #10.

@lloydchang lloydchang closed this Oct 23, 2023
This was referenced Oct 23, 2023
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeekTrainer GeekTrainer Awaiting requested review from GeekTrainer GeekTrainer is a code owner

@peckjon peckjon Awaiting requested review from peckjon peckjon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lloydchang