Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Repository files and Gem build #536

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Cleanup Repository files and Gem build #536

merged 5 commits into from
Dec 16, 2024

Conversation

rzhade3
Copy link
Contributor

@rzhade3 rzhade3 commented Dec 8, 2024

This PR updates this repository to remove extraneous files, update the README.md, and remove files from the Gem build.

Closes #531

All PRs:

  • Has tests
  • Documentation updated

Adding a new header

Generally, adding a new header is always OK.

  • Is the header supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the header?
  • Where does the specification live?

Adding a new CSP directive

  • Is the directive supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the directive?

@rzhade3 rzhade3 requested a review from KyFaSt December 8, 2024 18:43
@@ -1 +0,0 @@
3.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason I suppose, although I was thinking that having this locked the version to a very specific version only in development. Since we intend to support this library for at least Ruby 2.6-3.2, I figured it'd be better to unlock the development version. Not strongly opinonated though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-added the file so the Ruby version is pinned in dev

@rzhade3 rzhade3 merged commit 6d583bd into main Dec 16, 2024
13 checks passed
@rzhade3 rzhade3 deleted the rzhade3/cleanup-files branch December 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non necessary files from bundled Ruby Gem
2 participants