Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An actions- and pull request-based release workflow #158

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

CleanCut
Copy link
Contributor

This PR sets up workflows to generate release PR's (by manually starting an actions workflow) and automatically publishing releases to crates.io when the PR is merged.

Note: This needs to be merged in order to test it out.

@Copilot Copilot bot review requested due to automatic review settings January 17, 2025 23:37
@CleanCut CleanCut requested a review from a team as a code owner January 17, 2025 23:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • crates/twirp-build/LICENSE: Language not supported
  • crates/twirp/LICENSE: Language not supported
  • script/publish.sh: Language not supported
  • .github/workflows/create-release-pr.yml: Evaluated as low risk
  • .github/workflows/publish-release.yml: Evaluated as low risk
  • CONTRIBUTING.md: Evaluated as low risk
  • Cargo.toml: Evaluated as low risk
  • README.md: Evaluated as low risk

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@CleanCut CleanCut changed the title Set up a pull request and actions based release workflow An actions- and pull request-based release workflow Jan 21, 2025
Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Merge it and let's see what it can do.


## Usage

See the [example](./example) for a complete example project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this link still work? I think it probably needs to be ../example now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, I didn't think to look for relative links in the moved markdown. Thanks, I pushed up a fix!

crates/twirp/README.md Outdated Show resolved Hide resolved
Co-authored-by: Jason Orendorff <[email protected]>
@CleanCut CleanCut added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 4418b13 Jan 22, 2025
2 checks passed
@CleanCut CleanCut deleted the release-plz branch January 22, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants