Update to http 1.0 and hyper 1.1 on hard mode #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, without taking a dependency on `axum`. This isn't finished; I have this compiler error: ``` error: implementation of `From` is not general enough --> crates/twirp/src/test.rs:40:9 | 40 | tokio::spawn(test_server_handle_connection(io, router)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ implementation of `From` is not general enough | = note: `Box<(dyn StdError + std::marker::Send + Sync + 'static)>` must implement `From<Box<(dyn StdError + std::marker::Send + Sync + '0)>>`, for any lifetime `'0`... = note: ...but it actually implements `From<Box<(dyn StdError + std::marker::Send + Sync + 'static)>>` ``` The surprising thing about this error is if you replace the body of the function being called here, `test_server_handle_connction`, with `todo!()`, without changing the function signature, the type error goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, without taking a dependency on
axum.The difficult part of this was actually getting any code using the crate to compile anymore, now that
Serveris gone. It looks easy if you just skim the diff, but when I gave up last night I was getting this error fromrustc:This was with bf94528. The surprising thing about this error was if you replace the body of the function being called here,
test_server_handle_connction, withtodo!(), without changing the function signature, the type error goes away. 😬rust has achieved the ultimate in safety, i can't get an http server to compile